Separate docs preview deployment#773
Merged
Merged
Conversation
cncastillo
added
the
documentation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 90.01% 88.68% -1.34%
==========================================
Files 74 74
Lines 5179 5171 -8
==========================================
- Hits 4662 4586 -76
- Misses 517 585 +68
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
|
Preview available: https://juliahealth.github.io/KomaMRI.jl/previews/PR773/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: PR docs CI was deploying previews directly to the shared
gh-pagesbranch, so concurrent preview writes could reject withfetch firstand fail the required Documentation check.Solution: make
docs/make.jldeploy only onpushor explicitpush_preview; have PR CI only build docs; move PR preview deployment/commenting intoDocs Previewafter a successful Documentation job. Preview deploy/cleanup now share one non-CI concurrency group.Validation:
actionlinton touched workflows; YAML parse;git diff --check;docs/make.jlparse check.